-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First draft of JOSS Paper #76
Conversation
JOSS also requires us to include the following in the paper:
Do you think that mentioning the ongoing CPT work will be sufficient? Any other projects/work that we could mention? |
@NoraLoose regarding relating the ongoing CPT work -- I have a notebook/tutorial on how to apply GCM-filters to performing the combined spatial and temporal filtering that I've mentioned in the past. The goal was to have a spatial filter that would create a consistent filter scale across the various resolutions of NW2. I initially had trouble applying the package to do this because of lack of convergence at large filter scales that were several times the local deformation radius (which I think is physically relevant when we want to filter out mesoscale eddies). I eventually got this working by coarsening to 1/4 degree and then performing the filtering. I know Hemant already contributed a tutorial where he demonstrated how to coarsen/filter, but I'd be happy to share what I've done in NeverWorld2 as another example of filtering on a non-uniform and large filter scale related to the deformation radius (if it doesn't overlap with what's already been included). |
We can cite the paper on essoar. |
@NoraLoose Thanks. I am also using gcm-filters for vorticity budget analysis in global models. There is no manuscript to cite as the work is in the early stage. |
@ElizabethYankovsky I guess my question was more directed at published/citable work that we could list in a subsection of the JOSS paper. (I think this is what the JOSS requirement means.) So citing the JAMES gcm-filters paper, led by Ian, would be a good option. But independent of that, more examples for the documentation are always welcome! The documentation already has an example, in which NeverWorld2 data is filtered to the spatially-varying deformation radius. And we have Hemant's coarsening/filtering tutorial as well. But I'm sure your example would add something new! Alternatively, an example with MOM5 data (like for the JAMES paper) would be great too. But just to be clear, none of these would be essential for moving forward with the JOSS paper I think. |
FWIW, I don't think we should let the performance enhancements being discussed in #45 hold up the JOSS submission. |
Thanks for your comment, @rabernat! I agree. Refactoring the package to use numba for a performance improvement would be really valuable, but it will take some time. I think it makes sense to submit the JOSS paper soon. Do we still want to document the current performance, for example with a figure like you posted here? I think this could be an interesting addition to the paper and/or the documentation. PS: Any idea why |
I am very confused. I don't actually remember merging this. I did merge #78. Something weird is going on. |
Ok, I think I know what happened. I think you started working on #78 from a branch that already included 75cb16f (the final commit in this PR). So when we merged #78, this PR was automatically considered merged as well, even though no one clicked "merge." However, #78 went on to include more commits such as 53fbb54, which explicitly removed those files. That's why they are not appearing. We have two options:
|
Sorry about the mess. Not sure what I did there. Anyway, I just opened a new PR that adds the same files. |
We are making good progress on our project board with ticking off issues toward submitting the JOSS paper!
paper.md
includes a first draft of the paper - I'm happy to hear feedback and comments.paper.pdf
is the compiled version. #47 includes a useful checklist for the paper.Notes: